Skip to content

Update warning messages about undefined variables #8912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update warning messages about undefined variables #8912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ab5454
Update warning messages to note that undefined variables will become …
Jul 3, 2022
b15983b
Latin 1 charset for strcmp
Jul 3, 2022
534dbf9
Additional latin-1 encoding fixes of files dealing with binary strings.
Jul 3, 2022
8475101
Fix failing strlen.phpt
cmb69 Dec 17, 2022
e0a29f5
Lowercase this at request of CMB
Jan 2, 2023
8858ca7
Lowercase this at request of CMB
Jan 2, 2023
5484541
Fix missed tests
Jan 3, 2023
6c9b20d
Finally finally.
Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
216 changes: 108 additions & 108 deletions Zend/tests/019.phpt
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions Zend/tests/024.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,30 +15,30 @@ var_dump($a->$b->{$c[1]});

?>
--EXPECTF--
Warning: Undefined variable $a in %s on line %d
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %s on line %d

Warning: Trying to access array offset on value of type null in %s on line %d
NULL

Warning: Undefined variable $a in %s on line %d
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined variable $c in %s on line %d
Warning: Undefined variable $c (this will become an error in PHP 9.0) in %s on line %d

Warning: Trying to access array offset on value of type null in %s on line %d
NULL

Warning: Undefined variable $a in %s on line %d
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %s on line %d
int(1)

Warning: Undefined variable $a in %s on line %d
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined variable $b in %s on line %d
Warning: Undefined variable $b (this will become an error in PHP 9.0) in %s on line %d
int(0)

Warning: Undefined variable $a in %s on line %d
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %s on line %d
NULL

Warning: Undefined variable $b in %s on line %d
Warning: Undefined variable $b (this will become an error in PHP 9.0) in %s on line %d
int(1)

Warning: Attempt to read property "1" on int in %s on line %d
Expand All @@ -47,7 +47,7 @@ NULL
Warning: Attempt to read property "1" on int in %s on line %d
NULL

Warning: Undefined variable $c in %s on line %d
Warning: Undefined variable $c (this will become an error in PHP 9.0) in %s on line %d

Warning: Trying to access array offset on value of type null in %s on line %d

Expand Down
6 changes: 3 additions & 3 deletions Zend/tests/033.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ try {

?>
--EXPECTF--
Warning: Undefined variable $arr in %s on line %d
Warning: Undefined variable $arr (this will become an error in PHP 9.0) in %s on line %d

Warning: Trying to access array offset on value of type null in %s on line %d

Expand All @@ -37,7 +37,7 @@ Warning: Trying to access array offset on value of type null in %s on line %d

Warning: Trying to access array offset on value of type null in %s on line %d

Warning: Undefined variable $arr in %s on line %d
Warning: Undefined variable $arr (this will become an error in PHP 9.0) in %s on line %d

Warning: Trying to access array offset on value of type null in %s on line %d

Expand All @@ -49,7 +49,7 @@ Warning: Trying to access array offset on value of type null in %s on line %d

Warning: Trying to access array offset on value of type null in %s on line %d

Warning: Undefined variable $arr in %s on line %d
Warning: Undefined variable $arr (this will become an error in PHP 9.0) in %s on line %d

Warning: Trying to access array offset on value of type null in %s on line %d

Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/array_unpack/undef_var.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var_dump([...$arr]);

?>
--EXPECTF--
Warning: Undefined variable $arr in %s on line %d
Warning: Undefined variable $arr (this will become an error in PHP 9.0) in %s on line %d

Fatal error: Uncaught Error: Only arrays and Traversables can be unpacked in %s:%d
Stack trace:
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/arrow_functions/002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ var_dump((fn() => $b + $c)());

?>
--EXPECTF--
Warning: Undefined variable $c in %s on line %d
Warning: Undefined variable $c (this will become an error in PHP 9.0) in %s on line %d
int(1)
4 changes: 2 additions & 2 deletions Zend/tests/arrow_functions/003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ var_dump($fn());

?>
--EXPECTF--
Warning: Undefined variable $a in %s on line %d
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %s on line %d
NULL

Warning: Undefined variable $5 in %s on line %d
Warning: Undefined variable $5 (this will become an error in PHP 9.0) in %s on line %d
NULL
2 changes: 1 addition & 1 deletion Zend/tests/assign_coalesce_007.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ $a[0] ??= $a;
var_dump($a);
?>
--EXPECTF--
Warning: Undefined variable $a in %sassign_coalesce_007.php on line 2
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %sassign_coalesce_007.php on line 2
array(1) {
[0]=>
NULL
Expand Down
4 changes: 2 additions & 2 deletions Zend/tests/assign_dim_op_undef.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ $a[$b] += 1;
var_dump($a);
?>
--EXPECTF--
Warning: Undefined variable $a in %s on line %d
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined variable $b in %s on line %d
Warning: Undefined variable $b (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined array key "" in %s on line %d
array(1) {
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug30162.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ $db = new hariCow;
var_dump($db);
?>
--EXPECTF--
Warning: Undefined variable $db in %s on line %d
Warning: Undefined variable $db (this will become an error in PHP 9.0) in %s on line %d
NULL
object(hariCow)#%d (2) {
["x"]=>
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug31720.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ try {
}
?>
--EXPECTF--
Warning: Undefined variable $nonesuchvar in %s on line %d
Warning: Undefined variable $nonesuchvar (this will become an error in PHP 9.0) in %s on line %d
array_walk(): Argument #2 ($callback) must be a valid callback, first array member is not a valid class name or object
2 changes: 1 addition & 1 deletion Zend/tests/bug39036.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ var_dump($key);
echo "Done\n";
?>
--EXPECTF--
Warning: Undefined variable $key in %s on line %d
Warning: Undefined variable $key (this will become an error in PHP 9.0) in %s on line %d
NULL
Done
2 changes: 1 addition & 1 deletion Zend/tests/bug41209.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var_dump(isset($cache[$id]));
echo "Done\n";
?>
--EXPECTF--
Fatal error: Uncaught ErrorException: Undefined variable $id in %s:%d
Fatal error: Uncaught ErrorException: Undefined variable $id (this will become an error in PHP 9.0) in %s:%d
Stack trace:
#0 %s(%d): env::errorHandler(2, 'Undefined varia...', '%s', %d)
#1 {main}
Expand Down
14 changes: 7 additions & 7 deletions Zend/tests/bug43201.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,39 +26,39 @@ Notice: Indirect modification of overloaded property Foo::$arr has no effect in

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 14

Warning: Undefined variable $ref in %s on line %d
Warning: Undefined variable $ref (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined variable $undef in %s on line %d
Warning: Undefined variable $undef (this will become an error in PHP 9.0) in %s on line %d

Deprecated: chop(): Passing null to parameter #1 ($string) of type string is deprecated in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Warning: Undefined variable $undef in %s on line %d
Warning: Undefined variable $undef (this will become an error in PHP 9.0) in %s on line %d

Deprecated: chop(): Passing null to parameter #1 ($string) of type string is deprecated in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Warning: Undefined variable $undef in %s on line %d
Warning: Undefined variable $undef (this will become an error in PHP 9.0) in %s on line %d

Deprecated: chop(): Passing null to parameter #1 ($string) of type string is deprecated in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Warning: Undefined variable $undef in %s on line %d
Warning: Undefined variable $undef (this will become an error in PHP 9.0) in %s on line %d

Deprecated: chop(): Passing null to parameter #1 ($string) of type string is deprecated in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Warning: Undefined variable $undef in %s on line %d
Warning: Undefined variable $undef (this will become an error in PHP 9.0) in %s on line %d

Deprecated: chop(): Passing null to parameter #1 ($string) of type string is deprecated in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Warning: Undefined variable $undef in %s on line %d
Warning: Undefined variable $undef (this will become an error in PHP 9.0) in %s on line %d

Deprecated: chop(): Passing null to parameter #1 ($string) of type string is deprecated in %s on line %d

Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug47109.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ Bug #47109 (Memory leak on $a->{"a"."b"} when $a is not an object)
$a->{"a"."b"};
?>
--EXPECTF--
Warning: Undefined variable $a in %s on line %d
Warning: Undefined variable $a (this will become an error in PHP 9.0) in %s on line %d

Warning: Attempt to read property "ab" on null in %s on line %d
4 changes: 2 additions & 2 deletions Zend/tests/bug52001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ var_dump($temp1);
function a($b,$c) {}
?>
--EXPECTF--
Warning: Undefined variable $var in %s on line %d
Warning: Undefined variable $var (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined variable $ in %s on line %d
Warning: Undefined variable $ (this will become an error in PHP 9.0) in %s on line %d
int(1)
26 changes: 13 additions & 13 deletions Zend/tests/bug52041.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,47 +47,47 @@ foo()[0][0] += 2;
var_dump(foo());
?>
--EXPECTF--
Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d
Attempt to assign property "a" on null

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d
Attempt to modify property "a" on null

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d
Attempt to increment/decrement property "a" on null

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d
Attempt to modify property "a" on null

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d
Attempt to assign property "a" on null

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d
Attempt to modify property "a" on null

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined array key 0 in %s on line %d

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined array key 0 in %s on line %d

Warning: Undefined array key 0 in %s on line %d

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined array key 0 in %s on line %d

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d

Warning: Undefined array key 0 in %s on line %d

Warning: Undefined array key 0 in %s on line %d

Warning: Undefined variable $x in %s on line %d
Warning: Undefined variable $x (this will become an error in PHP 9.0) in %s on line %d
NULL
4 changes: 2 additions & 2 deletions Zend/tests/bug61767.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ register_shutdown_function(function(){
$undefined->foo();
?>
--EXPECTF--
Error handler called (Undefined variable $undefined)
Error handler called (Undefined variable $undefined (this will become an error in PHP 9.0))

Fatal error: Uncaught ErrorException: Undefined variable $undefined in %sbug61767.php:%d
Fatal error: Uncaught ErrorException: Undefined variable $undefined (this will become an error in PHP 9.0) in %sbug61767.php:%d
Stack trace:
#0 %sbug61767.php(%d): {closure}(%s, 'Undefined varia...', '%s', %d)
#1 {main}
Expand Down
4 changes: 2 additions & 2 deletions Zend/tests/bug67314.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ crash();
echo "ok\n";
?>
--EXPECTF--
Warning: Undefined variable $i in %s on line %d
Warning: Undefined variable $i (this will become an error in PHP 9.0) in %s on line %d
made it once

Warning: Undefined variable $i in %s on line %d
Warning: Undefined variable $i (this will become an error in PHP 9.0) in %s on line %d
ok
2 changes: 1 addition & 1 deletion Zend/tests/bug70124.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ try {
}
?>
--EXPECTF--
Warning: Undefined variable $f in %s on line %d
Warning: Undefined variable $f (this will become an error in PHP 9.0) in %s on line %d
string(34) "Value of type null is not callable"
string(31) "Call to undefined method A::y()"
string(31) "Call to undefined method A::y()"
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug72944.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ define('e', 'e');
echo "OK\n";
?>
--EXPECTF--
Warning: Undefined variable $A in %s on line %d
Warning: Undefined variable $A (this will become an error in PHP 9.0) in %s on line %d
OK
10 changes: 5 additions & 5 deletions Zend/tests/bug75921.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,21 +47,21 @@ unset($null);
--EXPECTF--
Attempt to assign property "a" on null

Warning: Undefined variable $null in %s on line %d
Warning: Undefined variable $null (this will become an error in PHP 9.0) in %s on line %d
NULL
Attempt to modify property "a" on null

Warning: Undefined variable $null in %s on line %d
Warning: Undefined variable $null (this will become an error in PHP 9.0) in %s on line %d
NULL
Attempt to modify property "a" on null

Warning: Undefined variable $null in %s on line %d
Warning: Undefined variable $null (this will become an error in PHP 9.0) in %s on line %d
NULL
Attempt to modify property "a" on null

Warning: Undefined variable $null in %s on line %d
Warning: Undefined variable $null (this will become an error in PHP 9.0) in %s on line %d
NULL
Attempt to modify property "a" on null

Warning: Undefined variable $null in %s on line %d
Warning: Undefined variable $null (this will become an error in PHP 9.0) in %s on line %d
NULL
2 changes: 1 addition & 1 deletion Zend/tests/bug76667.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ try {
}
?>
--EXPECTF--
Warning: Undefined variable $undefined in %s on line %d
Warning: Undefined variable $undefined (this will become an error in PHP 9.0) in %s on line %d

Warning: Attempt to read property "1" on null in %s on line %d
Division by zero
8 changes: 4 additions & 4 deletions Zend/tests/bug78531.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ try {
}
?>
--EXPECTF--
Warning: Undefined variable $u1 in %s on line %d
Warning: Undefined variable $u1 (this will become an error in PHP 9.0) in %s on line %d
Attempt to assign property "a" on null

Warning: Undefined variable $u2 in %s on line %d
Warning: Undefined variable $u2 (this will become an error in PHP 9.0) in %s on line %d
Attempt to increment/decrement property "a" on null

Warning: Undefined variable $u3 in %s on line %d
Warning: Undefined variable $u3 (this will become an error in PHP 9.0) in %s on line %d
Attempt to increment/decrement property "a" on null

Warning: Undefined variable $u4 in %s on line %d
Warning: Undefined variable $u4 (this will become an error in PHP 9.0) in %s on line %d
Attempt to modify property "a" on null
4 changes: 2 additions & 2 deletions Zend/tests/bug79599.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ try{
}
?>
--EXPECT--
string(21) "Undefined variable $b"
string(21) "Undefined variable $c"
string(60) "Undefined variable $b (this will become an error in PHP 9.0)"
string(60) "Undefined variable $c (this will become an error in PHP 9.0)"
2 changes: 1 addition & 1 deletion Zend/tests/bug79828.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function foo(): AnyType {
foo();
?>
--EXPECTF--
Warning: Undefined variable $uninitialized in %s on line %d
Warning: Undefined variable $uninitialized (this will become an error in PHP 9.0) in %s on line %d

Fatal error: Uncaught TypeError: foo(): Return value must be of type AnyType, null returned in %s:%d
Stack trace:
Expand Down
Loading