Allocate JIT bufer close to PHP .text segment to allow using direct IP-relative calls and jumps #8890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P-relative calls and jumps This implementation is based on php#8618
|
@dstogov We have looked at the patch. The code logic is much simpler and understandable, and code flow goes smoothly. Our test showed that JIT buffer now hit after [heap], and benchmark with this patch achieved performance gain 1) 4kb pages +2.7%, and 2) huge pages +2.8%. It looks good to merge the patch... (and then drop and close PR #8618) |
|
Terrific! |
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jul 2, 2022
…BSD. Follow up on php#8890 using similar workflow, we go through the php binary mapping per address boundaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is based on #8618