Skip to content

Don't shortcut empty oparray executions if zend_execute_ex has been overridden #8845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

derickr
Copy link
Member

@derickr derickr commented Jun 22, 2022

This fixes the situation from 67bb792#r76630925, which was the cause for some @xdebug functionality becoming broken in PHP 8.2.

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

derickr added a commit that referenced this pull request Jun 22, 2022
@derickr
Copy link
Member Author

derickr commented Jun 22, 2022

Merged, but GitHub didn't auto close it, so doing that myself.

@derickr derickr closed this Jun 22, 2022
@derickr derickr deleted the deoptimize-calling-empty-eval-statement-oparrays branch June 24, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants