Tweak $count range check of array_fill() #8804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`start_key + num` is supposed to fit into a `zend_long`, so we should not allow to pass values which won't. We also fix the `UNEXPECTED(EXPECTED(…))`, which does not make sense, and replace the magic number with the respective macro.
arnaud-lb
reviewed
Jun 17, 2022
This is by design, and is supposed to have the same behavior like doing the operations manually. We add a test to verify this behavior.
cmb69
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_key + numis supposed to fit into azend_long, so we shouldnot allow to pass values which won't.
We
alsofix theUNEXPECTED(EXPECTED(…)), which does not make sense,and replace the magic number with the respective macro. We also add a test case to verify the expected behavior for an
array_fill()edge case.