Skip to content

fix use after free #8796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix use after free #8796

wants to merge 2 commits into from

Conversation

hwde
Copy link
Contributor

@hwde hwde commented Jun 15, 2022

No description provided.

devnexen
devnexen approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your change makes sense

@devnexen
Copy link
Member

I suggest however to retarget to the PHP-8.0 branch.

@hwde hwde changed the base branch from master to PHP-8.0 June 16, 2022 06:59
@hwde hwde changed the base branch from PHP-8.0 to master June 16, 2022 07:01
@hwde hwde changed the base branch from master to PHP-8.0 June 16, 2022 07:03
iluuu1994
iluuu1994 requested changes Jun 16, 2022
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit should be rebased or cherry-picked onto PHP-8.0.

@hwde hwde changed the base branch from PHP-8.0 to master June 16, 2022 11:09
@hwde
Copy link
Contributor Author

hwde commented Jun 16, 2022

Guess I have to create a new PR, rebase won't go through, and cherry-pinking within same PR isn't possible?

@devnexen devnexen closed this in a83363e Jun 16, 2022
@hwde hwde deleted the fpm_evaluate_full_path-use-after-free branch June 16, 2022 12:11
@cmb69
Copy link
Member

cmb69 commented Jun 16, 2022

You could have rebased onto the desired target branch, force-pushed, and then changed the target branch in the UI (selectbox). However, that also can be done by the "merger". :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 requested changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwde @devnexen @cmb69 @iluuu1994 @saundefined