Skip to content

Fix GH-8756 : oci_new_descriptor() triggers dynamic property deprecation #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fix GH-8756 : oci_new_descriptor() triggers dynamic property deprecation #8758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8155e1b
Declare OCILob descriptor property
adoy Jun 12, 2022
d509a70
Declare OCICollection collection property
adoy Jun 12, 2022
cf4c315
Add type declaration in stub
adoy Jan 26, 2023
2c56ef4
Remove #[\AllowDynamicProperties]
adoy Jan 26, 2023
1069dd6
Reuse old errors to ensure that tests are still working
adoy Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ext/oci8/oci8.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,8 +951,10 @@ function oci_register_taf_callback($connection, ?callable $callback): bool {}
/** @param resource $connection */
function oci_unregister_taf_callback($connection): bool {}

#[\AllowDynamicProperties]
class OCILob {
/** @var resource */
public mixed $descriptor = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I managed to understand, the property is private indeed as you guessed... Would be nice to double check with someone else and change the visibility accordingly. If someone later complains, we can still make it public again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's why I asked @cjbj for a confirmation. I'm not an OCI user and looking at some tests I see stuff like unset($clob->descriptor);.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't have time to look at this until next month :(


/**
* @alias oci_lob_save
* @tentative-return-type
Expand Down Expand Up @@ -1080,8 +1082,9 @@ public function close(): bool {}
public function free(): bool {}
}

#[\AllowDynamicProperties]
class OCICollection {
/** @var resource */
public mixed $collection = null;
/**
* @alias oci_free_collection
* @tentative-return-type
Expand Down
20 changes: 11 additions & 9 deletions ext/oci8/oci8_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading