Fix regression from GH-8587

[iluuu1994]

Streams hold a reference to the stream wrapper. User stream wrappers
must not be released until the streams themselves are closed.

• Does overriding stream_closer mean the stream has to be closed manually now? No
• I'm not sure if user_wrapper_opendir is also closed through user_wrapper_close. I haven't figured out how to trigger that code path yet.

@nicolas-grekas FYI

[iluuu1994]

@cmb69 Do you know if php_stream_wrapper_ops.dir_opener can be tested or is this essentially dead code (or exclusively used for extensions)? I can only see it being used in _php_stream_opendir which is itself unused.

[cmb69]

I can only see it being used in _php_stream_opendir which is itself unused.

The stream function prefixed with underscore are usually not called directly, but rather the respective macros without that prefix. php_stream_opendir() is used several times in php-src, e.g. by DirectoryIterator::__construct().

[iluuu1994]

@cmb69 Oh sorry, I totally missed that one usage was a macro. Sorry.

[cmb69]

np

The streams layer is in need of better documentation; there is https://github.com/php/php-src/blob/master/docs/streams.md, but that is incomplete and likely not really up to date, and should probably better be moved to phpinternalsbook.com.

[iluuu1994]

Sorry for the delay. Should be good now. @nicolas-grekas Can you verify that this fixes your issue?

[nicolas-grekas]

Works like a charm, thank you!

[nicolas-grekas]

Is there anything pending on this PR? The issue keeps the Symfony CI red, I'm eager to see it fixed ;)

[iluuu1994]

I was just waiting for the build to be green 🙂

[OskarStark]

Should this be kept?