Skip to content

Use standard C99 uint8_t type instead of u_char type #8610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented May 23, 2022

No description provided.

@cmb69
Copy link
Member

cmb69 commented May 23, 2022

Thank you! Looks reasonable. Since there are more occurrences of u_char in php-src, we cannot yet get rid of

#if defined(_MSC_VER)
# ifndef u_char
typedef unsigned __int8 u_char;
# endif
#endif /* !_MSC_VER */

But we should probably fix the erroneous typedef right away.

@Girgias
Copy link
Member Author

Girgias commented May 23, 2022

u_char

I didn't realise this as only this failed on the other PR. But I will indeed go and fix them. Just waiting for CI to be sure this works before merging

@Girgias Girgias merged commit 59b4fdb into php:master May 23, 2022
@Girgias Girgias deleted the crypt_freesec_refactor branch May 23, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants