FPM add routing view global option (for FreeBSD for now). #8470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
May 11, 2022
sapi/fpm/fpm/fpm_sockets.c
Outdated
| @@ -386,6 +406,23 @@ static int fpm_socket_af_unix_listening_socket(struct fpm_worker_pool_s *wp) /* | |||
| } | |||
| /* }}} */ | |||
|
|
|||
| #ifdef HAVE_SOCKETROUTE | |||
| static int fpm_socket_setroute_init(void) /* {{{ */ | |||
There was a problem hiding this comment.
Is there a reason for not returning bool or zend_result?
There was a problem hiding this comment.
no reason in particular indeed :-)
devnexen
force-pushed
the
fpm_setfib_option
branch
from
d1b946c to
925bb73
Compare
bukka
requested changes
Jul 2, 2022
set the route table FIB id to the sockets created within FPM up to the max set by the system, avoiding having to use setfib command line.
devnexen
force-pushed
the
fpm_setfib_option
branch
from
925bb73 to
aac88a3
Compare
bukka
requested changes
Jul 3, 2022
devnexen
force-pushed
the
fpm_setfib_option
branch
from
aac88a3 to
b3429d7
Compare
|
@devnexen Implementation looks good to me. Let me know what you think about the potential test. If you think it doesn't make sense to add, it should be fine if you describe how you test it and if all works fine. But think some basic stub of the test would be awesome! |
we change the value for boot time.
bukka
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set the route table FIB id to the sockets created within FPM up to
the max set by the system, avoiding having to use setfib command line.