Fix multi-same-name-fields in Curl for old (> 7.56.0) versions #8460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While ext/curl now compiles for me (using curl 7.52.1), curl_postfields_array.phpt fails with: POST /get.inc?test=raw HTTP/1.1
Host: %s
Accept: */*
005+ Expect: 100-continue
Content-Type: multipart/form-data; boundary=------------------------%s
006-
007- --------------------------%s
008- Content-Disposition: form-data; name="single"
009-
010- SingleValue
011- --------------------------%s
012- Content-Disposition: form-data; name="multi"
013-
014- Multi1
015- --------------------------%s
016- Content-Disposition: form-data; name="multi"
017-
018- Multi2
019- --------------------------%s-- |
|
Ah, that didn't run locally: |
Without this explicitly set, curl might decide to add a `Expect: 100-continue` header if it deems the request too large. See also: https://gms.tf/when-curl-sends-100-continue.html
derickr
added a commit
that referenced
this pull request
Apr 29, 2022
|
Merged, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.