adding memmem fallback implementation proposal. #8391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
memmem_impl
branch
2 times, most recently
from
48a9ab8 to
e5be53c
Compare
|
This is for the usage in libmagic? I think it would make more sense to replace it with zend_memnstr, which is our optimized implementation of this functionality. |
|
ah right I did not notice these, thanks. |
|
cc @weltling |
|
If we modify libmagic, that modification also needs to be in libmagic.patch; otherwise, the modification will likely be overwritten after updating libmagic. |
|
ping :-) @cmb69 |
cmb69
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
must be a rare occurence nowadays tough.