Fix openssl_csr_export() stub #8362
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with current documentation of
openssl_csr_export()
function:From the documentation:
openssl_csr_export — Exports a CSR as a string
The
$output
parameter was changed fromstring
toOpenSSLAsymmetricKey
in 9f44ecaThis was probably just a mistake due to the first
$csr
parameter type being changed fromresource
to dedicated data type, along with otheropenssl_*
functions. The function actually crashes when passed a reference to a variable of typeOpenSSLAsymmetricKey
.Here's a test that crashes: