Fix opcache testing in CI #8350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Apr 12, 2022
| @@ -68,25 +68,28 @@ jobs: | |||
| with: | |||
| runTestsParameters: >- | |||
| ${{ matrix.run_tests_parameters }} | |||
| - name: Test Tracing JIT | |||
| - name: Test OpCache | |||
There was a problem hiding this comment.
I belive testing opcache prior /w JIT is better
There was a problem hiding this comment.
It's intentionally chosen this way because tracing jit has a higher chance of failing.
There was a problem hiding this comment.
yes, exactly - the way it is now will fail the CI pipeline earlier, which is definitely not wanted for nightly pipeline
with opcache /wo JIT first, CI will report correctly if the issue is opcache itself or related /w JIT only
makes sense?
mvorisek
commented
Apr 12, 2022
mvorisek
force-pushed
the
fix_opcache_ci_macos
branch
from
64f7a93 to
c8ca933
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix JIT testing on MacOS & unify the config across platforms
discovered in #7563 (comment) discussion