opcache posix creating special shared segments for FreeBSD 13 and above. #8037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
opcache_large_shm_posix
branch
from
bd3b4d7 to
b4e7420
Compare
dstogov
reviewed
Oct 9, 2023
ext/opcache/shared_alloc_posix.c
Outdated
Comment on lines
54
to
86
| shared_segment->shm_fd = shm_open(shared_segment_name, O_RDWR|O_CREAT|O_TRUNC, 0600); | ||
| shared_segment->shm_fd = | ||
| #if defined(HAVE_SHM_CREATE_LARGEPAGE) | ||
| shared_segment_lg_index > 0 ? | ||
| shm_create_largepage(shared_segment_name, shared_segment_flags, shared_segment_lg_index, SHM_LARGEPAGE_ALLOC_DEFAULT, shared_segment_mode) : | ||
| #endif | ||
| shm_open(shared_segment_name, shared_segment_flags, shared_segment_mode); |
There was a problem hiding this comment.
May be it makes sense to fallback to shm_open if shm_create_largepage is failed?
dstogov
reviewed
Oct 9, 2023
| shared_segment_lg_index > 0 ? | ||
| shm_create_largepage(shared_segment_name, shared_segment_flags, shared_segment_lg_index, SHM_LARGEPAGE_ALLOC_DEFAULT, shared_segment_mode) : | ||
| #endif | ||
| shm_open(shared_segment_name, shared_segment_flags, shared_segment_mode); | ||
| if (shared_segment->shm_fd == -1) { | ||
| *error_in = "shm_open"; |
There was a problem hiding this comment.
"shm_open" name may be wrong now.
There was a problem hiding this comment.
if we do fallback from the large page flavor to the traditional shm_open it might not.
There was a problem hiding this comment.
yes. but now you don't fallback.
dstogov
requested changes
Oct 9, 2023
From this release, it is permitted to create shared memory blocks tagged as large for faster accesses for a size compatible with otherwise we fallback to a classic creation.
devnexen
force-pushed
the
opcache_large_shm_posix
branch
from
b4e7420 to
327d05a
Compare
dstogov
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this release, it is permitted to create shared memory blocks tagged
as large for faster accesses for a size compatible with otherwise
we fallback to a classic creation.