Skip to content

ext/opcache: check mkstemp() return value right after the call #8031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2022
Merged

ext/opcache: check mkstemp() return value right after the call #8031

merged 1 commit into from
Feb 5, 2022

Conversation

MaxKellermann
Copy link
Contributor

Don't call fchmod(-1), which is not only wrong, but also clobbers
errno and sets it to EBADF, breaking the following errno access for
the log message.

@MaxKellermann
ext/opcache: check mkstemp() return value right after the call
9ab7982 
Don't call fchmod(-1), which is not only wrong, but also clobbers
errno and sets it to EBADF, breaking the following errno access for
the log message.
@MaxKellermann
Copy link
Contributor Author

CI failures unrelated to this PR:

##[error]No hosted parallelism has been purchased or granted. To request a free parallelism grant, please fill out the following form ...

@Girgias Girgias merged commit 0199b22 into php:master Feb 5, 2022
@MaxKellermann MaxKellermann deleted the mkstemp-errno branch February 6, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxKellermann @nikic @Girgias