Skip to content

fpm memory leak fix proposal on invalid port. #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fpm memory leak fix proposal on invalid port. #7911

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jan 8, 2022

No description provided.

cmb69
cmb69 reviewed Jan 8, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch, thank you! An alternative might be to add a label just before the free() at the end of the function, and to goto there.

@devnexen
Copy link
Member Author

devnexen commented Jan 8, 2022

sure but would have been more worthy if there were more error code paths eventually.

@cmb69 cmb69 closed this in c99a026 Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @cmb69