Fix class synopsis generation #7891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Jan 6, 2022
| @@ -1558,14 +1558,14 @@ public function getFieldSynopsisElement(DOMDocument $doc): DOMElement | |||
| } | |||
|
|
|||
| private function getFieldSynopsisType(): Type { | |||
| if ($this->type) { | |||
There was a problem hiding this comment.
We have a readonly mixed property which is indeed a resource. On the contrary, the real type is displayed for params and returns because their PHPDoc type hint is usually invalid (e.g. true, false|null etc.)
| @@ -2019,10 +2019,6 @@ public static function getClassSynopsisReference(Name $name): string { | |||
| */ | |||
| private function collectInheritedMembers(array &$parentsWithInheritedProperties, array &$parentsWithInheritedMethods, array $classMap): void | |||
| { | |||
| if ($this->type !== "class") { | |||
There was a problem hiding this comment.
usually, inherited members of interfaces are also displayed in the manual
| @@ -2033,7 +2029,7 @@ private function collectInheritedMembers(array &$parentsWithInheritedProperties, | |||
| $parentsWithInheritedProperties[$parent->toString()] = $parent; | |||
| } | |||
|
|
|||
| if (!empty($parentInfo->funcInfos) && !isset($parentsWithInheritedMethods[$parent->toString()])) { | |||
| if (!isset($parentsWithInheritedMethods[$parent->toString()]) && $parentInfo->hasMethods()) { | |||
There was a problem hiding this comment.
on the other hand, constructors are usually not displayed as inherited members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few fixes which were necessary for me to do when syncing stubs with the docs.