Skip to content

Remove libmysql support from mysqli #7889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2022
Merged

Remove libmysql support from mysqli #7889

merged 5 commits into from
May 30, 2022

Conversation

kamil-tekiela
Copy link
Member

@kamil-tekiela kamil-tekiela commented Jan 5, 2022 •
edited
Loading

cmb69
cmb69 reviewed Jan 5, 2022
View reviewed changes
cmb69
cmb69 reviewed Jan 5, 2022
View reviewed changes
@kamil-tekiela kamil-tekiela force-pushed the remove-libmysql-support-from-mysqli branch from fcd29e1 to 5870d98 Compare January 5, 2022 22:15
@kamil-tekiela
Copy link
Member Author

kamil-tekiela commented Jan 5, 2022 •
edited
Loading

Addressed review comments and removed all mysqli code related to libmysql support

@cmb69 cmb69 added the RFC label Jan 7, 2022
@cmb69

This comment was marked as outdated.

Sign in to view
@kamil-tekiela kamil-tekiela force-pushed the remove-libmysql-support-from-mysqli branch 2 times, most recently from 185ede1 to 5612548 Compare February 5, 2022 15:17
Girgias
Girgias reviewed Feb 6, 2022
View reviewed changes
@Ayesh
Copy link
Member

Ayesh commented Feb 6, 2022

I think we can also remove mysqli.reconnect INI directive, given it was only effective with libmysql anyway.

@cmb69
Copy link
Member

cmb69 commented Feb 14, 2022

@kamil-tekiela, are the AppVeyor test failures (e.g. mysqli_driver.phpt) spurious?

@kamil-tekiela kamil-tekiela force-pushed the remove-libmysql-support-from-mysqli branch from df614a6 to a0d7190 Compare February 14, 2022 12:45
@kamil-tekiela
Copy link
Member Author

@kamil-tekiela, are the AppVeyor test failures (e.g. mysqli_driver.phpt) spurious?

Failures were valid. I removed reconnect property and I forgot to update tests.

@kamil-tekiela kamil-tekiela force-pushed the remove-libmysql-support-from-mysqli branch from a0d7190 to 327d3f6 Compare February 23, 2022 23:07
@kamil-tekiela kamil-tekiela added this to the PHP 8.2 milestone Feb 25, 2022
@kamil-tekiela kamil-tekiela mentioned this pull request Mar 15, 2022
Closed
@ramsey
Copy link
Member

ramsey commented May 27, 2022

RFC was accepted Feb 5th. Looks like this patch is complete and waiting for reviews.

Please resolve the conflicts.

Is there anything else that needs to be done before we can merge this?

@kamil-tekiela kamil-tekiela force-pushed the remove-libmysql-support-from-mysqli branch from 327d3f6 to 2b509b2 Compare May 29, 2022 18:45
@kamil-tekiela
Copy link
Member Author

RFC was accepted Feb 5th. Looks like this patch is complete and waiting for reviews.

Please resolve the conflicts.

Is there anything else that needs to be done before we can merge this?

I rebased. I don't think this PR needs anything else. The previous review comments were unactionable IMHO.

cmb69
cmb69 approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all legit review comments have been addressed, so this is good to be merged.

@kamil-tekiela kamil-tekiela merged commit 23b0257 into php:master May 30, 2022
jrfnl added a commit to jrfnl/php-src that referenced this pull request Jul 31, 2023
@jrfnl
Remove mysqli.reconnect from php.ini files
1e2463f 
The `mysqli.reconnect` ini directive was removed in PHP 8.2.0.

Refs:
* https://github.com/php/php-src/blob/5d90c5057dbf88cea49ac53daf5f4622c1588a84/UPGRADING#L320
* php#7889
* php@be3d55d
@jrfnl jrfnl mentioned this pull request Jul 31, 2023
Closed
@jrfnl jrfnl mentioned this pull request Aug 10, 2023
Merged
@cedric-anne cedric-anne mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
RFC Waiting on Review
Projects
None yet
Milestone
PHP 8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@kamil-tekiela @cmb69 @Ayesh @ramsey @Girgias