Fix zend_observer_fcall_end_all() accessing dangling pointers #7885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beberlei
force-pushed
the
bug81430-missing-trampoline
branch
3 times, most recently
from
2f01f60 to
08f6e16
Compare
cmb69
reviewed
Jan 7, 2022
By switching attribute constructor stackframe to be called via trampoline the stack allocation is not causing dangling pointers in the zend_observer API anymore. Co-Authored-By: Florian Sowade <f.sowade@suora.com> Co-Authored-By: Christopher Becker <cmbecker69@gmx.de> Co-Authored-By: Dmitry Stogov <dmitry@zend.com>
beberlei
force-pushed
the
bug81430-missing-trampoline
branch
from
08f6e16 to
4a9e05f
Compare
|
Looks good. |
|
@javer, we do not push bug fixes to release branches after the RC had been tagged (what happened a week ago). When the bug fix addresses a serious issue, there might be an exemption from this rule, but in this case it looks like there are still unresolved issues, so it's unlikely that this will be in PHP 8.1.2. But there will be PHP 8.1.3 only four weeks later. But finally this decision is up to the release managers to make: @krakjoe, @patrickallaert, @ramsey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By switching attribute constructor stackframe to be called via trampoline the stack allocation is not causing dangling pointers in the zend_observer API anymore that lead to crashes.
Follow up to #7665 and 76e2a83