Remove JMPZNZ opcode #7857
Closed
Remove JMPZNZ opcode #7857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikic is this the first attempt to remove JMPZNZ? I've found a similar local patch dated by 04 October 2019. |
|
@dstogov I don't remember doing this before, so it's probably your patch :) |
shivammathur
added a commit
to shivammathur/xdebug
that referenced
this pull request
Jan 11, 2022
JMPZNZ opcode has been removed in PHP 8.2. So this limits the handling of the JMPZNZ opcode to lower versions. Ref: php/php-src#7857
mvorisek
pushed a commit
to mvorisek/xdebug
that referenced
this pull request
Apr 1, 2022
JMPZNZ opcode has been removed in PHP 8.2. So this limits the handling of the JMPZNZ opcode to lower versions. Ref: php/php-src#7857
shivammathur
added a commit
to shivammathur/xdebug
that referenced
this pull request
Jun 25, 2022
JMPZNZ opcode has been removed in PHP 8.2. So this limits the handling of the JMPZNZ opcode to lower versions. Ref: php/php-src#7857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dstogov I'm not sure if the JMPZNZ opcode still provides a value. While it can avoid execution of separate JMP opcode in some cases, it also prevents smart branch optimization, so creating JMPZNZ may be detrimental in practice. If there's no clear benefit to it, I think we should drop it to reduce number of cases that the optimizer needs to handle.