Skip to content

mysqli_result::__construct should throw exceptions #7855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2021
Merged

mysqli_result::__construct should throw exceptions #7855

merged 1 commit into from
Dec 30, 2021

Conversation

kamil-tekiela
Copy link
Member

Just like the corresponding functions mysqli_use_result and mysqli_store_result

@cmb69
Copy link
Member

cmb69 commented Dec 30, 2021

It might be sensible to add a test case for this.

@kamil-tekiela
Copy link
Member Author

It might be sensible to add a test case for this.

True, but I just can't come up with a suitable test case that wouldn't be bad for performance. I think there was a test for this but I just can't remember which one.

cmb69
cmb69 approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think we can merge this without test case.

@kamil-tekiela kamil-tekiela merged commit 50c7512 into php:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamil-tekiela @cmb69