Fix FILTER_FLAG_NO_RES_RANGE flag #7790
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`2001:10::/28` is a reversed IPv6 range. But there's a typo in #7476, which caused IPv6 address like `240b:0010::1` will be filtered by the flag `FILTER_FLAG_NO_RES_RANGE`. http://www.faqs.org/rfcs/rfc6890.html
|
Thank you! That looks correct, but it might be a good idea to add some tests for this. Also note that this should not target PHP-7.4, because that branch is open for security fixes only. It may not be necessary to rebase onto PHP-8.0, though. |
|
Thanks for your review. I've added some testcases for this pr and change the base branch to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2001:10::/28is a reversed IPv6 range. But there's a typo in #7476, which caused IPv6 address like240b:0010::1will be filtered by the flagFILTER_FLAG_NO_RES_RANGE.http://www.faqs.org/rfcs/rfc6890.html