Fix bug GH-7746 (mysqli_sql_exception->sqlstate is inaccessible)

[kamil-tekiela]

Fixes #7746

The property should not have been protected ever. It was meant to be public.

[damianwadley]

Like I just commented on 7746, PHP's own exceptions typically use private/protected variables and provide getter methods instead. This way the exception can be immutable.

[kamil-tekiela]

I can write a getter method for this, but I would need help. How do I read a property? Is there a helper macro for this?

[kocsismate]

How do I read a property?

You have to use zend_read_property(). Some context about this function: #6759 (Nikita's comments)

[cmb69]

Regarding the name of the accompanying regression test (bugGH7746.phpt): I'm fine with this naming convention. Should we document that on http://qa.php.net/write-test.php#naming-conventions?

[nikic]

I'd target this at PHP-8.1, don't think adding a new method this late in the 8.0 release cycle is a good idea in terms of version constraints.

Regarding the name of the accompanying regression test (bugGH7746.phpt): I'm fine with this naming convention. Should we document that on http://qa.php.net/write-test.php#naming-conventions?

I'd go for either just gh7756.phpt or issue7756.phpt.

[cmb69]

I'd go for either just gh7756.phpt or issue7756.phpt.

I suggested the former but @Danack made a good point that having "bug" in the filename makes it more explicit that it's a regression test. I have no strong opinion either way.

[cmb69]

Thank you! This looks good to me.