-
Notifications
You must be signed in to change notification settings - Fork 7.9k
socket ancillary data, FreeBSD implementation. #7708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2f152ac
to
cf86c1a
Compare
cf86c1a
to
e3beab8
Compare
e3beab8
to
bf95f60
Compare
bf95f60
to
3c0a00a
Compare
Codecov Report
@@ Coverage Diff @@
## master #7708 +/- ##
=======================================
Coverage 67.32% 67.32%
=======================================
Files 803 803
Lines 302556 302556
=======================================
Hits 203688 203688
Misses 98868 98868 Continue to review full report at Codecov.
|
16a0529
to
f7f29ba
Compare
ping :) |
ping :) @cmb69 |
ping :) |
ping :) @bukka if you can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to read a bit of docs to understand it a little bit but from what I understood it makes sense to me to add it even though it's quite platform specific. Do you think there's any point to also support LOCAL_CREDS
(e.g. for NetBSD)?
ye, will try to do a new PR once merged. |
ping @bukka :-) |
@devnexen I already approved it so you can merge it. Just don't forget to update NEWS and UPGRADING and maybe change the commit message to follow the format that we use (starting with capitalized verb...). E.g. something like: |
Ah I can t merge it :-) but I can still update the other entries. |
e4aabee
to
005d134
Compare
@@ -246,6 +246,7 @@ PHP 8.2 UPGRADE NOTES | |||
. TCP_KEEPIDLE (Linux, others) | |||
. TCP_KEEPINTVL (Linux, others) | |||
. TCP_NOTSENT_LOWAT | |||
. LOCAL_CREDS_PERSISTENT (FreeBSD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also SCM_CREDS2
added, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
using LOCAL_CREDS_PERSISTENT/SCM_CREDS2 instead so we also get the send process id.
@devnexen It might make sense you request the access here: https://www.php.net/git-php.php . It's still good idea then to do PR's and try to get reviews but it should speed things up for you and also save a bit of my and other core devs time... :) In case you need then more info about our gitflow, see https://wiki.php.net/vcs/gitworkflow |
using LOCAL_CREDS_PERSISTENT instead so we also get the send process id.