Skip to content

socket ancillary data, FreeBSD implementation. #7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Dec 3, 2021

using LOCAL_CREDS_PERSISTENT instead so we also get the send process id.

@devnexen devnexen force-pushed the anc_data_fbsd branch 2 times, most recently from 2f152ac to cf86c1a Compare December 3, 2021 00:55
@codecov-commenter
Copy link

Codecov Report

Merging #7708 (9c6b843) into master (9c6b843) will not change coverage.
The diff coverage is n/a.

❗ Current head 9c6b843 differs from pull request most recent head 3c0a00a. Consider uploading reports for the commit 3c0a00a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7708   +/-   ##
=======================================
  Coverage   67.32%   67.32%           
=======================================
  Files         803      803           
  Lines      302556   302556           
=======================================
  Hits       203688   203688           
  Misses      98868    98868           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6b843...3c0a00a. Read the comment docs.

@devnexen devnexen force-pushed the anc_data_fbsd branch 3 times, most recently from 16a0529 to f7f29ba Compare December 22, 2021 16:01
@devnexen
Copy link
Member Author

ping :)

@devnexen
Copy link
Member Author

ping :) @cmb69

@devnexen
Copy link
Member Author

ping :)

@devnexen
Copy link
Member Author

ping :) @bukka if you can

Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to read a bit of docs to understand it a little bit but from what I understood it makes sense to me to add it even though it's quite platform specific. Do you think there's any point to also support LOCAL_CREDS (e.g. for NetBSD)?

@devnexen
Copy link
Member Author

ye, will try to do a new PR once merged.

@devnexen
Copy link
Member Author

devnexen commented Jun 1, 2022

ping @bukka :-)

@bukka
Copy link
Member

bukka commented Jun 2, 2022

@devnexen I already approved it so you can merge it. Just don't forget to update NEWS and UPGRADING and maybe change the commit message to follow the format that we use (starting with capitalized verb...). E.g. something like: Extend socket ancillary data on FreeBSD or whatever makes better sense... :)

@devnexen
Copy link
Member Author

devnexen commented Jun 2, 2022

Ah I can t merge it :-) but I can still update the other entries.

@devnexen devnexen force-pushed the anc_data_fbsd branch 2 times, most recently from e4aabee to 005d134 Compare June 2, 2022 12:36
@@ -246,6 +246,7 @@ PHP 8.2 UPGRADE NOTES
. TCP_KEEPIDLE (Linux, others)
. TCP_KEEPINTVL (Linux, others)
. TCP_NOTSENT_LOWAT
. LOCAL_CREDS_PERSISTENT (FreeBSD)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also SCM_CREDS2 added, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

using LOCAL_CREDS_PERSISTENT/SCM_CREDS2 instead so we also get the send process id.
@bukka bukka merged commit f813520 into php:master Jun 2, 2022
@bukka
Copy link
Member

bukka commented Jun 2, 2022

@devnexen It might make sense you request the access here: https://www.php.net/git-php.php . It's still good idea then to do PR's and try to get reviews but it should speed things up for you and also save a bit of my and other core devs time... :) In case you need then more info about our gitflow, see https://wiki.php.net/vcs/gitworkflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants