Don't run sapi/fpm tests in parallel with other fpm tests #7696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion on php#7561 fpm tests have been spuriously failing in CI, with 2 parallel workers on 2 CPUs. `make test TESTS='sapi/fpm/tests -j8'` fails locally for me without this change They're trying to listen on IPv4 on 127.0.0.1 on the same port as other tests (e.g. helper getPort()=9008 on 64-bit architecture (PHP_INT_SIZE=8)). So tests will fail if 1. php-fpm is still running from another test in parallel. 2. a request is sent to a server for a different test.
|
Parallelism should already be disabled: https://github.com/php/php-src/blob/master/sapi/fpm/tests/CONFLICTS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion on #7561
fpm tests have been spuriously failing in CI, with 2 parallel workers
on 2 CPUs.
make test TESTS='sapi/fpm/tests -j8'fails locally for mewithout this change
They're trying to listen on IPv4 on 127.0.0.1 on the same port as other
tests (e.g. helper getPort()=9008 on 64-bit architecture (PHP_INT_SIZE=8)).
So tests will fail (in the old setup) if