-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Refactor dba_(p)open() to be more sensible #7610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b877791
to
51eeaf4
Compare
Hmm, not sure if we can do that for BC reasons; I guess there may be custom handlers out there. |
This should address the octal issue encountered in #7610.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine
It doesn't look like it's possible to register a custom handler, the list is hardcoded. |
I can imagine that some customize this. However, if we document the change, we should be good. |
I've tested on a couple more drivers, and found a memory leak in the TokyoCabinet driver which I need to backport to 7.4 and above. The only drivers I haven't tested the changes on now are |
Maybe we can enable more dba handlers in CI (the ones that don't conflict)? |
I'll to figure this out, need to find the Ubuntu dependencies as I'm running on Fedora. Will make this as a separate PR I think |
Actually use ZPP Throw ValueErrors for invalid values Use dedicated struc members for file permission and map size instead of a zval stack
Actually use ZPP
Throw ValueErrors for invalid values