Fix for libargon2 not being used when compiled in #7538
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7965bc3.
|
I see that a similar change was attempted for PHP 7.4 but ultimately reverted due to the state of I personally think not accepting this PR and finding an alternate solution would probably be better overall. However I'm just not experienced enough to know how to improve that (other than by this revert). |
This reverts commit 964918f.
mallardduck
changed the title
nikic
approved these changes
Sep 30, 2021
mallardduck
added a commit
to mallardduck/homebrew-php
that referenced
this pull request
Oct 1, 2021
In PHP 8.1 argon2 lib is found using pkg-config/pkgconfig - because of this the flag no longer needs (or uses) any input values. Having it included shouldn't hurt anything, but it also doesn't provide any affect when building PHP. --- Additionally, the current HEAD for PHP 8.1 has a bug, but the fix for that bug is here: php/php-src#7538 Once that merges in libargon2 should work fine again - tho as this is technically a related but not-dependent change that's why I'm proposing this before that is merged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing line to the
ext/standard/config.m4file. Currently the block to loadlibargon2does not defineHAVE_ARGON2LIBto true. The result of this is that none of thelibargon2specific features work at all.This leads to users hitting the
Unexpected failure hashing passworderror if the build does not includelibsodium. Or iflibsodiumis included it this causes the "threads greater than 1 not valid error".EDIT: PR message updated to reflect actual root issue and fix.