Allow passing false to the $length parameter of substr #7533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, it's possible to pass
false
as a value for the length parameter of thesubstr()
function:However, when strict types are enabled, passing false currently throws the following error:
This causes a break in the dev version of Doctrine: doctrine/orm#8878
I wonder if we should fix the documentation or fix the code.
In this PR, I tried to fix the code, but as the test failure shows, changing the stub file isn't enough. We also have to add a slightly more heavy parameter parsing logic and I wonder if it is worth it.
What do you think?