Skip to content

Add more specific array return type hints for various extensions - part 1 #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add more specific array return type hints for various extensions - part 1 #7432

wants to merge 2 commits into from
+51 −6

Conversation

kocsismate
Copy link
Member

ext/bz2, ext/calendar, ext/dba, ext/enchant, ext/ffi

@kocsismate
Add more specific array return type hints for various extensions - pa…
2c2d931 
…rt 1

ext/bz2, ext/calendar, ext/dba, et/enchant, ext/ffi
@krakjoe krakjoe added the Type Information Label should be used whenever a pull request is working to improve type information for core or o+ label Aug 31, 2021
@kocsismate kocsismate changed the base branch from master to PHP-8.1 September 5, 2021 18:52
@kocsismate
Copy link
Member Author

@nikic do you see value in these PRs? If so, can you please review them?

nikic
nikic approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@nikic nikic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with the FFI (method) change dropped (or moved to some other PR dealing with methods only, so we can land it once they are supported).

@kocsismate
Copy link
Member Author

LG with the FFI (method) change dropped (or moved to some other PR dealing with methods only, so we can land it once they are supported).

Oops, yes, I forgot that they are not supported. Of course, I'll get rid of that one when applying.

@kocsismate kocsismate closed this in d02b9b9 Nov 7, 2021
@kocsismate kocsismate deleted the stub-array-2 branch November 7, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Type Information Label should be used whenever a pull request is working to improve type information for core or o+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @nikic @krakjoe