Declare a few missing function return types #7395
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Aug 24, 2021
| */ | ||
| function resourcebundle_get(ResourceBundle $bundle, $index, bool $fallback = true) {} | ||
| /** @param string|int $index */ | ||
| function resourcebundle_get(ResourceBundle $bundle, $index, bool $fallback = true): mixed {} |
There was a problem hiding this comment.
As far as I saw, only a float return type is impossible, so using mixed seems to be warranted.
| */ | ||
| function intltz_create_enumeration($countryOrRawOffset = null) {} | ||
| /** @param IntlTimeZone|string|int|float|null $countryOrRawOffset */ | ||
| function intltz_create_enumeration($countryOrRawOffset = null): IntlIterator|false {} |
There was a problem hiding this comment.
I'm not sure why this one was missed. The return type seems straightforward.
| @@ -1423,8 +1423,7 @@ function uniqid(string $prefix = "", bool $more_entropy = false): string {} | |||
|
|
|||
| /* url.c */ | |||
|
|
|||
| /** @return mixed */ | |||
| function parse_url(string $url, int $component = -1) {} | |||
| function parse_url(string $url, int $component = -1): int|string|array|false {} | |||
There was a problem hiding this comment.
I could also go back to mixed if the current specific return type is unnecessary
kocsismate
force-pushed
the
stub-return-fixes
branch
from
4e4f0a7 to
fe80f51
Compare
nikic
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these missing return types when I regenerated the optimizer func info.