Skip to content

Fix return types in community job #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate force-pushed the community-return-type-fix branch 3 times, most recently from 0740562 to 59a76a5 Compare July 20, 2021 23:17
@nikic
Copy link
Member

nikic commented Jul 21, 2021

I think it would make more sense to patch PHP to not include the deprecation for this job (until compatibility is a bit better).

@kocsismate
Copy link
Member Author

I think it would make more sense to patch PHP to not include the deprecation for this job (until compatibility is a bit better).

Is patching PHP any better than running phpunit like this: php vendor/bin/phpunit -d error_reporting=E_ALL^E_DEPRECATION?

BTW do you know if the memory leaks in Laravel are related to the tentative return types or they were present previously as well?

@nikic
Copy link
Member

nikic commented Jul 21, 2021

I think it would make more sense to patch PHP to not include the deprecation for this job (until compatibility is a bit better).

Is patching PHP any better than running phpunit like this: php vendor/bin/phpunit -d error_reporting=E_ALL^E_DEPRECATION?

If that works, then that would probably be ideal. Can we write that into the ini file so it applies to all tests?

@kocsismate kocsismate force-pushed the community-return-type-fix branch from 5049dc6 to 7393529 Compare July 21, 2021 08:34
@kocsismate
Copy link
Member Author

If that works, then that would probably be ideal.

Hmm, the deprecated notices are gone now, but a fatal error emerged due to a tentative return type :( So probably something still converts the deprecation to a fatal error

@kocsismate kocsismate force-pushed the community-return-type-fix branch from 206ba7f to 1880488 Compare August 6, 2021 11:35
@kocsismate kocsismate closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants