Sccp new functions for ct #7220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
force-pushed
the
SCCP-new-functions-for-CT
branch
from
fabc5e1 to
c9b4fb8
Compare
mvorisek
reviewed
Jul 7, 2021
| @@ -836,6 +837,7 @@ static bool can_ct_eval_func_call(zend_string *name, uint32_t num_args, zval **a | |||
| || zend_string_equals_literal(name, "str_split") | |||
| || zend_string_equals_literal(name, "str_starts_with") | |||
| || zend_string_equals_literal(name, "strpos") | |||
| || zend_string_equals_literal(name, "strstr") | |||
There was a problem hiding this comment.
strtolower etc ashould be added as well
There was a problem hiding this comment.
According to Nikita, it is locale dependant and can't be included here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.