Fix #74264: grapheme_sttrpos() broken for negative offsets #7189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must not assume that
usearch_last()
gives the proper result fornegative offsets. Instead we'd need to continue to search backwards
(
usearch_previous
) until we find a proper match. However, apparentlysearching backwards is broken, so we work around by searching forward
from the start of the string until we pass the
offset_pos
, and thenuse the previous result.