Rename Fiber::this() to Fiber::getCurrent() #7155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
approved these changes
Jun 15, 2021
| @@ -1,12 +1,12 @@ | |||
| --TEST-- | |||
| Fiber::this() | |||
| Fiber::getCurrent() | |||
There was a problem hiding this comment.
Would it be worth to also rename this file?
There was a problem hiding this comment.
Oops, missed that, thank you for pointing this out. Updated now.
|
@trowski consensus gathered or no ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, simple rename. I'll bring this up on the mailing list since this is a change from the API in the RFC.