Skip to content

JIT/AArch64: Optimize add+ldr to ldr #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2021
Merged

JIT/AArch64: Optimize add+ldr to ldr #7109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions ext/opcache/jit/zend_jit_arm64.dasc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2447,25 +2447,22 @@ static int zend_jit_trace_exit_stub(dasm_State **Dst)
| ldr REG0, EX->func
| ldr REG0, [REG0, #offsetof(zend_op_array, reserved[zend_func_info_rid])]
| ldr REG0, [REG0, #offsetof(zend_jit_op_array_trace_extension, offset)]
| add REG0, IP, REG0
| ldr REG0, [REG0]
| ldr REG0, [IP, REG0]
| br REG0
} else if (GCC_GLOBAL_REGS) {
| ldp x29, x30, [sp], # SPAD // stack alignment
| ldr REG0, EX->func
| ldr REG0, [REG0, #offsetof(zend_op_array, reserved[zend_func_info_rid])]
| ldr REG0, [REG0, #offsetof(zend_jit_op_array_trace_extension, offset)]
| add REG0, IP, REG0
| ldr REG0, [REG0]
| ldr REG0, [IP, REG0]
| br REG0
} else {
| ldr IP, EX->opline
| mov FCARG1x, FP
| ldr REG0, EX->func
| ldr REG0, [REG0, #offsetof(zend_op_array, reserved[zend_func_info_rid])]
| ldr REG0, [REG0, #offsetof(zend_jit_op_array_trace_extension, offset)]
| add REG0, IP, REG0
| ldr REG0, [REG0]
| ldr REG0, [IP, REG0]
| blr REG0
|
| tst RETVALw, RETVALw
Expand Down Expand Up @@ -3115,8 +3112,7 @@ static int zend_jit_trace_return(dasm_State **Dst, bool original_handler)
| ldr REG0, EX->func
| ldr REG0, [REG0, #offsetof(zend_op_array, reserved[zend_func_info_rid])]
| ldr REG0, [REG0, #offsetof(zend_jit_op_array_trace_extension, offset)]
| add REG0, IP, REG0
| ldr REG0, [REG0]
| ldr REG0, [IP, REG0]
| br REG0
}
} else if (GCC_GLOBAL_REGS) {
Expand All @@ -3127,8 +3123,7 @@ static int zend_jit_trace_return(dasm_State **Dst, bool original_handler)
| ldr REG0, EX->func
| ldr REG0, [REG0, #offsetof(zend_op_array, reserved[zend_func_info_rid])]
| ldr REG0, [REG0, #offsetof(zend_jit_op_array_trace_extension, offset)]
| add REG0, IP, REG0
| ldr REG0, [REG0]
| ldr REG0, [IP, REG0]
| br REG0
}
} else {
Expand All @@ -3137,8 +3132,7 @@ static int zend_jit_trace_return(dasm_State **Dst, bool original_handler)
| ldr REG0, EX->func
| ldr REG0, [REG0, #offsetof(zend_op_array, reserved[zend_func_info_rid])]
| ldr REG0, [REG0, #offsetof(zend_jit_op_array_trace_extension, offset)]
| add REG0, IP, REG0
| ldr REG0, [REG0]
| ldr REG0, [IP, REG0]
| blr REG0
}
| ldp FP, RX, T2 // retore FP and IP
Expand Down