Skip to content

Fix undefined return value of fiber after bailout #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2021
Merged

Fix undefined return value of fiber after bailout #7103

merged 1 commit into from
Jun 5, 2021

Conversation

twose
Copy link
Member

@twose twose commented Jun 5, 2021 •
edited
Loading

Commit 42dbd1f removed bailout case.
We always have to consider such edge cases.

@twose twose requested a review from trowski June 5, 2021 07:38
krakjoe
krakjoe approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@krakjoe krakjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted.

trowski
trowski approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@trowski trowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, totally forgot about shutdown functions.

@trowski trowski merged commit e2e770c into php:master Jun 5, 2021
@twose twose deleted the fiber-get-return-after-bailout branch June 7, 2021 01:52
Crell pushed a commit to Crell/php-src that referenced this pull request Jun 7, 2021
@twose @Crell
Fix undefined return value of fiber after bailout (php#7103)
c070642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trowski trowski trowski approved these changes

@krakjoe krakjoe krakjoe approved these changes

Assignees
No one assigned
Labels
Category: Fibers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twose @trowski @krakjoe