Skip to content

Update deprecation message for incompatible float to int conversion #7095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Zend/tests/array_offset.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ echo "Done\n";
--EXPECTF--
Warning: Undefined array key -1 in %s on line %d

Deprecated: Implicit conversion from non-compatible float -1.1 to int in %s on line %d
Deprecated: Implicit conversion from float -1.1 to int loses precision in %s on line %d

Warning: Undefined array key -1 in %s on line %d

Warning: Undefined array key -1 in %s on line %d

Deprecated: Implicit conversion from non-compatible float -1.1 to int in %s on line %d
Deprecated: Implicit conversion from float -1.1 to int loses precision in %s on line %d

Warning: Undefined array key -1 in %s on line %d
Done
10 changes: 5 additions & 5 deletions Zend/tests/bug46701.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ new foo;

?>
--EXPECTF--
Deprecated: Implicit conversion from non-compatible float 3428599296 to int in %s on line %d
Deprecated: Implicit conversion from float 3428599296 to int loses precision in %s on line %d

Deprecated: Implicit conversion from non-compatible float 3459455488 to int in %s on line %d
Deprecated: Implicit conversion from float 3459455488 to int loses precision in %s on line %d

Deprecated: Implicit conversion from non-compatible float 3459616768 to int in %s on line %d
Deprecated: Implicit conversion from float 3459616768 to int loses precision in %s on line %d
array(3) {
[-866368000]=>
int(1)
Expand All @@ -41,10 +41,10 @@ array(3) {
int(3)
}

Deprecated: Implicit conversion from non-compatible float 3459455488 to int in %s on line %d
Deprecated: Implicit conversion from float 3459455488 to int loses precision in %s on line %d
int(2)

Deprecated: Implicit conversion from non-compatible float 3459616768 to int in %s on line %d
Deprecated: Implicit conversion from float 3459616768 to int loses precision in %s on line %d
array(1) {
[-835350528]=>
int(3)
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug72347.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ function test() : int {
var_dump(test());
?>
--EXPECTF--
Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
float(1.5)
int(1)
2 changes: 1 addition & 1 deletion Zend/tests/constant_expressions_dynamic.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ var_dump(
--EXPECTF--
Warning: A non-numeric value encountered in %s on line %d

Deprecated: Implicit conversion from non-compatible float 3.14 to int in %s on line %d
Deprecated: Implicit conversion from float 3.14 to int loses precision in %s on line %d
int(3)
string(4) "1foo"
bool(false)
Expand Down
18 changes: 9 additions & 9 deletions Zend/tests/empty_str_offset.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -99,31 +99,31 @@ bool(true)
bool(false)
- double ---

Deprecated: Implicit conversion from non-compatible float -1.1 to int in %s on line %d
Deprecated: Implicit conversion from float -1.1 to int loses precision in %s on line %d
bool(false)

Deprecated: Implicit conversion from non-compatible float -10.5 to int in %s on line %d
Deprecated: Implicit conversion from float -10.5 to int loses precision in %s on line %d
bool(true)

Deprecated: Implicit conversion from non-compatible float -4.1 to int in %s on line %d
Deprecated: Implicit conversion from float -4.1 to int loses precision in %s on line %d
bool(true)

Deprecated: Implicit conversion from non-compatible float -0.8 to int in %s on line %d
Deprecated: Implicit conversion from float -0.8 to int loses precision in %s on line %d
bool(false)

Deprecated: Implicit conversion from non-compatible float -0.1 to int in %s on line %d
Deprecated: Implicit conversion from float -0.1 to int loses precision in %s on line %d
bool(false)

Deprecated: Implicit conversion from non-compatible float 0.2 to int in %s on line %d
Deprecated: Implicit conversion from float 0.2 to int loses precision in %s on line %d
bool(false)

Deprecated: Implicit conversion from non-compatible float 0.9 to int in %s on line %d
Deprecated: Implicit conversion from float 0.9 to int loses precision in %s on line %d
bool(false)

Deprecated: Implicit conversion from non-compatible float 3.141592653589793 to int in %s on line %d
Deprecated: Implicit conversion from float 3.141592653589793 to int loses precision in %s on line %d
bool(false)

Deprecated: Implicit conversion from non-compatible float 100.5001 to int in %s on line %d
Deprecated: Implicit conversion from float 100.5001 to int loses precision in %s on line %d
bool(true)
- array ---
bool(true)
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/float_to_int/union_int_string_type_arg.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ foo(10e500); // Infinity
--EXPECTF--
int(1)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)
string(3) "NAN"
string(8) "1.0E+121"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ var_dump($array[$string_float]);
int(0)
bool(true)

Deprecated: Implicit conversion from non-compatible float 1.0E+121 to int in %s on line %d
Deprecated: Implicit conversion from float 1.0E+121 to int loses precision in %s on line %d

Deprecated: Implicit conversion from non-compatible float 1.0E+121 to int in %s on line %d
Deprecated: Implicit conversion from float 1.0E+121 to int loses precision in %s on line %d
array(2) {
[0]=>
string(11) "Large float"
Expand All @@ -42,13 +42,13 @@ array(2) {
string(18) "String large float"
}

Deprecated: Implicit conversion from non-compatible float 1.0E+121 to int in %s on line %d
Deprecated: Implicit conversion from float 1.0E+121 to int loses precision in %s on line %d
string(1) "0"

Warning: Undefined array key "1.0E+121" in %s on line %d
NULL

Deprecated: Implicit conversion from non-compatible float 1.0E+121 to int in %s on line %d
Deprecated: Implicit conversion from float 1.0E+121 to int loses precision in %s on line %d
string(1) "0"

Warning: Undefined array key "1.0E+121" in %s on line %d
Expand Down
32 changes: 16 additions & 16 deletions Zend/tests/float_to_int/warnings_float_literals.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -71,43 +71,43 @@ var_dump($instance->a);
--EXPECTF--
Bitwise ops:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(-2)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(3)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(2)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(8)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(0)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(6)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)
Modulo:

Deprecated: Implicit conversion from non-compatible float 6.5 to int in %s on line %d
Deprecated: Implicit conversion from float 6.5 to int loses precision in %s on line %d
int(0)

Deprecated: Implicit conversion from non-compatible float 2.5 to int in %s on line %d
Deprecated: Implicit conversion from float 2.5 to int loses precision in %s on line %d
int(1)
Offset access:
Arrays:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
string(1) "b"

Deprecated: Implicit conversion from non-compatible float 2.5 to int in %s on line %d
Deprecated: Implicit conversion from float 2.5 to int loses precision in %s on line %d
array(3) {
[0]=>
string(1) "a"
Expand All @@ -125,16 +125,16 @@ Warning: String offset cast occurred in %s on line %d
string(3) "phz"
Function calls:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)

Deprecated: Implicit conversion from non-compatible float 60.5 to int in %s on line %d
Deprecated: Implicit conversion from float 60.5 to int loses precision in %s on line %d
string(1) "<"
Function returns:

Deprecated: Implicit conversion from non-compatible float 3.5 to int in %s on line %d
Deprecated: Implicit conversion from float 3.5 to int loses precision in %s on line %d
int(3)
Typed property assignment:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@ var_dump($var);
--EXPECTF--
Bitwise ops:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(3)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(2)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(6)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)
Modulo:

Deprecated: Implicit conversion from non-compatible float 2.5 to int in %s on line %d
Deprecated: Implicit conversion from float 2.5 to int loses precision in %s on line %d
int(1)
36 changes: 18 additions & 18 deletions Zend/tests/float_to_int/warnings_float_vars.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -93,49 +93,49 @@ var_dump($instance->a);
--EXPECTF--
Bitwise ops:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(-2)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(3)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(2)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(8)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(0)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(8)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(0)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(6)

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)
Modulo:

Deprecated: Implicit conversion from non-compatible float 6.5 to int in %s on line %d
Deprecated: Implicit conversion from float 6.5 to int loses precision in %s on line %d
int(0)

Deprecated: Implicit conversion from non-compatible float 2.5 to int in %s on line %d
Deprecated: Implicit conversion from float 2.5 to int loses precision in %s on line %d
int(1)
Offset access:
Arrays:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
string(1) "b"

Deprecated: Implicit conversion from non-compatible float 2.5 to int in %s on line %d
Deprecated: Implicit conversion from float 2.5 to int loses precision in %s on line %d
array(3) {
[0]=>
string(1) "a"
Expand All @@ -153,16 +153,16 @@ Warning: String offset cast occurred in %s on line %d
string(3) "phz"
Function calls:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)

Deprecated: Implicit conversion from non-compatible float 60.5 to int in %s on line %d
Deprecated: Implicit conversion from float 60.5 to int loses precision in %s on line %d
string(1) "<"
Function returns:

Deprecated: Implicit conversion from non-compatible float 3.5 to int in %s on line %d
Deprecated: Implicit conversion from float 3.5 to int loses precision in %s on line %d
int(3)
Typed property assignment:

Deprecated: Implicit conversion from non-compatible float 1.5 to int in %s on line %d
Deprecated: Implicit conversion from float 1.5 to int loses precision in %s on line %d
int(1)
26 changes: 13 additions & 13 deletions Zend/tests/float_to_int/warnings_string_float_literals.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -54,45 +54,45 @@ var_dump($instance->a);
--EXPECTF--
Bitwise ops:

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(3)

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(1)

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(2)

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(8)

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(0)

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(6)

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(1)
Modulo:

Deprecated: Implicit conversion from non-compatible float-string "6.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "6.5" to int loses precision in %s on line %d
int(0)

Deprecated: Implicit conversion from non-compatible float-string "2.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "2.5" to int loses precision in %s on line %d
int(1)
Function calls:

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(1)

Deprecated: Implicit conversion from non-compatible float-string "60.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "60.5" to int loses precision in %s on line %d
string(1) "<"
Function returns:

Deprecated: Implicit conversion from non-compatible float-string "3.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "3.5" to int loses precision in %s on line %d
int(3)
Typed property assignment:

Deprecated: Implicit conversion from non-compatible float-string "1.5" to int in %s on line %d
Deprecated: Implicit conversion from float-string "1.5" to int loses precision in %s on line %d
int(1)
Loading