JIT/AArch64: Code refactoring for macros #7082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the comments and rename arguments for some macros. The following macros are renamed: SAFE_MEM_ACC_WITH_UOFFSET -> MEM_ACC_64_WITH_UOFFSET SAFE_MEM_ACC_WITH_UOFFSET_32 -> MEM_ACC_32_WITH_UOFFSET SAFE_MEM_ACC_WITH_UOFFSET_BYTE -> MEM_ACC_8_WITH_UOFFSET MEM_STORE_BYTE_ZTS -> MEM_STORE_8_ZTS MEM_STORE_ZTS -> MEM_STORE_64_ZTS MEM_LOAD_ZTS -> MEM_LOAD_64_ZTS MEM_LOAD_BYTE_ZTS -> MEM_LOAD_8_ZTS ADD_IP_FROM_CST -> ADD_IP_WITH_CONST The following macros are deprecated and removed: SET_Z_PTR, GET_Z_W2, SET_Z_W2 Change-Id: I767cf70f373e5f5a1090079e70f8e953a654da00
It's more accurate to use "MEM_ACCESS_*_WITH_UOFFSET" than "MEM_ACC_*_WITH_UOFFSET". Change-Id: I71479a809008848b61c4786016e6c10110e6aa8b
dstogov
reviewed
Jun 1, 2021
…_IMM As pointed by Dmitry, (int32_t) (1LL << 32) would make the assertion "TRUE", which is not expected by us. Change-Id: I767cf70f373e5f5a1090079e70f8e953a654da00
|
Thanks a lot for your review. @dstogov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the comments and rename arguments for some macros.
The following macros are renamed:
The following macros are deprecated and removed:
Change-Id: I767cf70f373e5f5a1090079e70f8e953a654da00