JIT/AArch64: [macos] Fix arguments to variadic function #7023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zend_throw_error() and zend_error() are variadic functions. In Linux, arguments are passed in registers, whereas they must be put on stack in Macos [1][2]. In this patch: 1. preprocessor macro "__APPLE__" is used to distinguish the OS. 2. the third argument "CARG3" is the only variadic argument and put on stack. 3. the invocation of zend_error() is converted back to regular call in zend_jit_undefined_offset_stub() and zend_jit_undefined_index_stub(). With this patch, all ~4k test cases can pass for "nonZTS+CALL" functional/tracing JIT with Macos Apple Silicion. [1] https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms#Overview [2] https://github.com/below/HelloSilicon#listing-9-1 Change-Id: I49bc3233fc253ad3e77e8664464ff3e830dcd183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend_throw_error() and zend_error() are variadic functions. In Linux,
arguments are passed in registers, whereas they must be put on stack in
Macos [1][2].
In this patch:
stack.
zend_jit_undefined_offset_stub() and zend_jit_undefined_index_stub().
With this patch, all ~4k test cases can pass for "nonZTS+CALL"
functional/tracing JIT with Macos Apple Silicion.
[1]
https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms#Overview
[2] https://github.com/below/HelloSilicon#listing-9-1
Change-Id: I49bc3233fc253ad3e77e8664464ff3e830dcd183