Skip to content

Add support for testing with Graviton2 #7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2021
Merged

Add support for testing with Graviton2 #7016

merged 2 commits into from
May 25, 2021

Conversation

janaknat
Copy link
Contributor

Travis CI supports running on AWS Graviton2 instances. For more information please see: https://blog.travis-ci.com/2020-09-11-arm-on-aws

Travis CI build logs for arm64 and arm64-graviton2: https://travis-ci.com/github/janaknat/php-src/builds/226356460

@janaknat janaknat mentioned this pull request May 19, 2021
@nikic
Copy link
Member

nikic commented May 21, 2021

What is the difference between the arm64 and the arm64-graviton2 archs? Is it a matter of arm64-graviton2 being faster? If that's the case, I think we can just replace the existing arm64 job with the arm64-graviton2 one, there would be no need to run both.

The main problem with our arm64 testing right now is that since Travis switched to the credit system, we only do a single nightly test run, while ideally we should be testing each PR/merge.

@janaknat
Copy link
Contributor Author

Yes, arm64-graviton2 is faster. It is backed by Graviton2 instances.

As per https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing 'Building on a public repositories only' point 4, OSS projects can request for credits. It might help with the testing.

I can update the PR to remove the arm64 job and have the arm64-graviton2 job alone.

The arm64-graviton2 job should be sufficient.
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's go with this variant then!

@nikic nikic merged commit 4a68067 into php:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants