Skip to content

Declare typed properties in ext/dom #7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Declare typed properties in ext/dom #7013

wants to merge 2 commits into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented May 19, 2021 •
edited
Loading

cc. @beberlei

@beberlei
Copy link
Contributor

If the tests pass, i would say lets go ahead.

nikic
nikic reviewed May 25, 2021
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but can you please add a test that triggers some type error?

@kocsismate
Copy link
Member Author

Looks reasonable to me, but can you please add a test that triggers some type error?

Yeah, of course! I'll do that a bit later.

@kocsismate kocsismate deleted the dom-typed-property branch May 26, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @beberlei @nikic