Allow named args after unpack #7009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have a test for what happens in case of |
Done! Yes, this also results in the overwrite error. |
mvorisek
reviewed
May 18, 2021
| echo $e->getMessage(), "\n"; | ||
| } | ||
| try { | ||
| test2(...[1, 'b' => 2], b: 20); |
There was a problem hiding this comment.
what about ...[1, 'b' => 2], 20, is it tested anywhere?
There was a problem hiding this comment.
Positional arguments after unpacking are forbidden in general (no relation to named args).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, argument unpacking and named arguments cannot be mixed at all. This relaxes the restriction to allow
foo(...$args, named: $arg). The variantfoo(named: $arg, ...$args)is forbidden, because we can't ensure that positional parameters come before named parameters in that case (without more intrusive changes). Effectively this just enforces a required style, as the order of unpack and named args doesn't matter for the cases where both could be well-defined.