Skip to content

adding FreeBSD to CI attempt. #6974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2021
Merged

adding FreeBSD to CI attempt. #6974

merged 1 commit into from
May 21, 2021

Conversation

devnexen
Copy link
Member

No description provided.

@krakjoe
Copy link
Member

krakjoe commented May 11, 2021

Typo: "freesd"

@krakjoe krakjoe self-assigned this May 11, 2021
@devnexen devnexen force-pushed the fbsd_ci branch 2 times, most recently from 8286b12 to 22bf11c Compare May 11, 2021 18:40
@krakjoe
Copy link
Member

krakjoe commented May 11, 2021

I begin to question if we've misunderstood what is possible: https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml ?

@devnexen
Copy link
Member Author

Yes just saw this list too so far only cirrus seems to provide freebsd

@devnexen
Copy link
Member Author

@krakjoe only repository owners can register to Cirrus.

@nikic
Copy link
Member

nikic commented May 14, 2021

@devnexen If I've done it right, it should be enabled now.

@devnexen devnexen force-pushed the fbsd_ci branch 2 times, most recently from 60b4458 to be5f850 Compare May 14, 2021 08:56
@krakjoe
Copy link
Member

krakjoe commented May 14, 2021

Sending extra perseverance to @devnexen ... this is the tricky bit.

Don't worry about noise and reopening/closing/generally making a mess while you're getting this to work ... experience tells us there isn't really another way ...

@devnexen devnexen force-pushed the fbsd_ci branch 11 times, most recently from 753aabd to c6146e4 Compare May 14, 2021 10:34
@nikic
Copy link
Member

nikic commented May 14, 2021

For gd, it should be enough to specify --enable-gd, there is no need to install libgd. I think that should avoid the build error you saw (though the recently landed 28e7add might address it as well).

@devnexen devnexen force-pushed the fbsd_ci branch 3 times, most recently from cb893fc to 66506ea Compare May 14, 2021 16:21
@devnexen
Copy link
Member Author

@krakjoe would it sound as a nice starting point as is ?

@krakjoe
Copy link
Member

krakjoe commented May 14, 2021

Well, it didn't complete a build, and I see a number of failures around various extensions ...

It would be good if we could get to the point where the build completes first of all, then we need to have a look at what tests are failing, and the reasons for those failures - in some cases we might need a variation test, in other cases there might be something we need to do on the host ...

When we have a build that runs to completion, I'll join in the with test changes ...

@devnexen devnexen changed the title WIP: adding FreeBSD to CI attempt. adding FreeBSD to CI attempt. May 18, 2021
@nikic nikic force-pushed the fbsd_ci branch 12 times, most recently from ec29c2a to 0e0635f Compare May 19, 2021 15:24
@nikic
Copy link
Member

nikic commented May 19, 2021

There are two remaining issues here. One is two test failures in intl, probably with the same root cause:

========DIFF========
     date:  Tuesday, July 7, 2009 8:41:13 PM EDT
002+ msgf:  Wednesday, July 8, 2009 12:41:13 AM utc
002- msgf:  Tuesday, July 7, 2009 8:41:13 PM usnyc
========DONE========
FAIL Bug #58756: w.r.t MessageFormatter [ext/intl/tests/bug58756_MessageFormatter_variant2.phpt]

========DIFF========
001+ quinta-feira, 17 de maio de 2012 4:35:36 da tarde utc
001- quinta-feira, 17 de maio de 2012 5:35:36 da tarde ptlis
========DONE========
FAIL MessageFormat accepts IntlCalendar args [ext/intl/tests/msgfmt_format_intlcalendar_variant4.phpt] 

I have already checked that this difference is not related to the use of ICU 69.1.

The other is that the parallel test running (-j2) ends up hanging. The non-parallel runner works fine.

@nikic nikic force-pushed the fbsd_ci branch 9 times, most recently from bfaa2f3 to 676d676 Compare May 21, 2021 08:37
@nikic
Copy link
Member

nikic commented May 21, 2021

I'm going to merge this in the hope that the test running hang is resolved ... unfortunately it's intermittent, so it's hard to say whether it's really fixed or not. I'll revert if it's not fixed.

@nikic nikic merged commit 90b843b into php:master May 21, 2021
@krakjoe
Copy link
Member

krakjoe commented May 21, 2021

@devnexen thanks for bringing this to completion with the help of Nikita, sorry I didn't find time to join in, was working on other things ... but this is great 👍

@devnexen
Copy link
Member Author

more kudos to nikic he did more here :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants