Skip to content

openssl_pkcs7_read: input is data not filename #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vjardin
Copy link
Contributor

@vjardin vjardin commented May 4, 2021

The argument should be an input string and not a filename.

Fix: php/doc-en#559
Suggested-by: George Peter Banyard girgias@php.net

The argument should be an input string and not a filename.

Fix: php/doc-en#559
Suggested-by: George Peter Banyard <girgias@php.net>
@ramsey
Copy link
Member

ramsey commented May 5, 2021

While it's definitely a bug that this is named input_filename when it should be data, I'm a little concerned about backwards compatibility with named parameters.

Thoughts?

@vjardin
Copy link
Contributor Author

vjardin commented May 5, 2021

This feature was undocumented and unused. So there is likely no one that will have such concern.

@nikic nikic closed this in bb0107b May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants