Don't mark ini as modified in begin silence #6904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dstogov Do you know of any reason why this code exists? |
It was intended to restore original EG(error_reporting) setting at the end of request in case of abnormal termination between BEGIN_SILENCE and END_SILENCE. It seems like we don't have another mechanism. |
nikic
added a commit
that referenced
this pull request
May 11, 2021
This guard against the issue that GH-6904 would introduce when run under --repeat 2 mode.
|
Thanks, we do need this code then. I added a test in 4fe07d4 to make sure the error_reporting restoring works correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually modify the value of the setting since PHP 7.0, so this is unnecessary.