Skip to content

simplexml_import_dom() - Basic test on invalid nodetype error #6901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

simplexml_import_dom() - Basic test on invalid nodetype error #6901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ext/simplexml/tests/simplexml_import_dom_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
simplexml_import_dom() - Basic test on invalid nodetype error
--SKIPIF--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the EXTENSIONS section: #6787

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. I'll be delighted to.

<?php
if (!extension_loaded('simplexml')) {
exit('Skip - SimpleXML extension not loaded');
}
?>
--FILE--
<?php
$x = new stdClass();

var_dump(simplexml_import_dom($x));
?>
--EXPECTF--
Warning: simplexml_import_dom(): Invalid Nodetype to import in %s on line %d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be an exception after my changes, and the arginfo/zpp mismatch will be gone from debug builds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now rebase on PHP-8.0, my fix has been merged


Fatal error: Arginfo / zpp mismatch during call of simplexml_import_dom() in %s on line %d