Add tests for handling of null bytes in password_hash() calls and error when using null w/ bcrypt #6897
+83
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or when using null w/ bcrypt
|
Test failed because of a forward slash in the expected output vs. a back slash in the actual output. |
|
@sgolemon bump, can you take a look at this please ? |
|
Internals discussion: https://externals.io/message/114090 |
|
This change looks somewhat controversial, and @sgolemon acknowledged that this should go through the RFC process. |
|
@sgolemon Are you planning on pursuing an RFC here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.