PHPDBG: fix bug parsing 3-word opcodes #6895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPDBG won't parse opcodes correctly if they are more than two words separated by underscores (as many opcodes, like ZEND_POST_INC, are). "Actual" output from this failing test is: ``` [Successful compilation of %s] prompt> [Breakpoint #0 added at ZEND_POST_INC] prompt> 1234 [Script ended normally] prompt> [Not running] prompt> [Not running] prompt> [Not running] prompt> [Not running] prompt> ```
Now opcodes that have more than one underscore (e.g. ZEND_POST_INC) are parsed correctly. This change gets the test added in the previous commit (sapi/phpdbg/tests/breakpoints_009.phpt) passing.
krakjoe
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPDBG wasn't parsing opcodes correctly if they were more than two words
separated by underscores (as many opcodes, like ZEND_POST_INC, are).
This adds a regression test. The output of that test prior to this fix was:
From that output you can see that the
ZEND_POST_INCopcode was not being parsed correctly, cause no breakpoints were being hit.