Fix #80960: opendir() warning wrong info when failed on Windows #6872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, we must not forget to set appropriate error codes for "manual" checks in `virtual_file_ex()`. Secondly, we must not call `php_error_docref2()` for warnings regarding unary functions; thus, we introduce `php_win32_docref1_from_error()`.
|
Ah, need to fix some other tests. |
`opendir()` is a unary function, and as such must not report two arguments.
The actual number of underscores varies depending on the path of the test case; let's not expect any particular number. Furthermore, we should not expect a certain failure message, since these are localized on Windows; it should be sufficient to check for the error code.
nikic
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, we must not forget to set appropriate error codes for "manual"
checks in
virtual_file_ex().Secondly, we must not call
php_error_docref2()for warnings regardingunary functions; thus, we introduce
php_win32_docref1_from_error().