Skip to content

Fixed bug #80900 #6861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed bug #80900 #6861

wants to merge 1 commit into from

Conversation

twose
Copy link
Member

@twose twose commented Apr 13, 2021

SCCP optimization marks the wrong target feasible when the constant is of the incorrect type.

I am just curious about this bug and have a try...
And this bug was introduced by db2ffcf so we need to fix it on PHP-7.4 instead of master.

@twose twose requested a review from dstogov April 13, 2021 07:46
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Interesting that nobody ran into this before.

Yes, this should go into the PHP-7.4 branch. You'll need to replace --EXTENSION-- with --SKIPIF-- in that case.

@twose twose changed the base branch from master to PHP-7.4 April 13, 2021 10:16
@twose
Copy link
Member Author

twose commented Apr 13, 2021

Make some improvements on the test script, it can also cover SWITCH_LONG now.

@twose twose closed this in 7c6cf09 Apr 13, 2021
@twose twose deleted the sccp branch April 13, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants